Yeuoly 196bfeaaf4 Merge branch 'main' into fix/chore-fix 10 months ago
..
advanced_chat 196bfeaaf4 Merge branch 'main' into fix/chore-fix 10 months ago
agent_chat 47c8824be6 feat: move model request to plugin daemon 10 months ago
chat 47c8824be6 feat: move model request to plugin daemon 10 months ago
completion 47c8824be6 feat: move model request to plugin daemon 10 months ago
workflow 196bfeaaf4 Merge branch 'main' into fix/chore-fix 10 months ago
README.md 7753ba2d37 FEAT: NEW WORKFLOW ENGINE (#3160) 1 year ago
__init__.py 7753ba2d37 FEAT: NEW WORKFLOW ENGINE (#3160) 1 year ago
base_app_generate_response_converter.py 47c8824be6 feat: move model request to plugin daemon 10 months ago
base_app_generator.py 47c8824be6 feat: move model request to plugin daemon 10 months ago
base_app_queue_manager.py 00d1c45518 Merge main 11 months ago
base_app_runner.py d0e0111f88 fix:Spark's large language model token calculation error #7911 (#8755) 10 months ago
message_based_app_generator.py 8c51d06222 feat: regenerate in `Chat`, `agent` and `Chatflow` app (#7661) 10 months ago
message_based_app_queue_manager.py 292220c596 chore: apply pep8-naming rules for naming convention (#8261) 11 months ago
workflow_app_runner.py 2cf1187b32 chore(api/core): apply ruff reformatting (#7624) 11 months ago
workflow_logging_callback.py 6613b8f2e0 chore: fix unnecessary string concatation in single line (#8311) 11 months ago

README.md

Guidelines for Database Connection Management in App Runner and Task Pipeline

Due to the presence of tasks in App Runner that require long execution times, such as LLM generation and external requests, Flask-Sqlalchemy's strategy for database connection pooling is to allocate one connection (transaction) per request. This approach keeps a connection occupied even during non-DB tasks, leading to the inability to acquire new connections during high concurrency requests due to multiple long-running tasks.

Therefore, the database operations in App Runner and Task Pipeline must ensure connections are closed immediately after use, and it's better to pass IDs rather than Model objects to avoid deattach errors.

Examples:

  1. Creating a new record:
   app = App(id=1)
   db.session.add(app)
   db.session.commit()
   db.session.refresh(app)  # Retrieve table default values, like created_at, cached in the app object, won't affect after close
   
   # Handle non-long-running tasks or store the content of the App instance in memory (via variable assignment).
   
   db.session.close()
   
   return app.id
  1. Fetching a record from the table:
   app = db.session.query(App).filter(App.id == app_id).first()
    
   created_at = app.created_at
    
   db.session.close()
   
   # Handle tasks (include long-running).
   
  1. Updating a table field:
   app = db.session.query(App).filter(App.id == app_id).first()

   app.updated_at = time.utcnow()
   db.session.commit()
   db.session.close()

   return app_id