fix disable endpoint not work (#17)

* fix disable endpoint not work

* fix disable endpoint

* refactor the disable endpoint

* fix comment

internal/service/endpoint.go

@@ -194,17 +194,8 @@ func Endpoint(
 }
 
 func EnableEndpoint(endpoint_id string, tenant_id string) *entities.Response {
-	endpoint, err := db.GetOne[models.Endpoint](
-		db.Equal("id", endpoint_id),
-		db.Equal("tenant_id", tenant_id),
-	)
-	if err != nil {
-		return exception.NotFoundError(errors.New("endpoint not found")).ToResponse()
-	}
-
-	endpoint.Enabled = true
 
-	if err := install_service.EnabledEndpoint(&endpoint); err != nil {
+	if err := install_service.EnabledEndpoint(endpoint_id, tenant_id); err != nil {
 		return exception.InternalServerError(errors.New("failed to enable endpoint")).ToResponse()
 	}
 
@@ -212,17 +203,8 @@ func EnableEndpoint(endpoint_id string, tenant_id string) *entities.Response {
 }
 
 func DisableEndpoint(endpoint_id string, tenant_id string) *entities.Response {
-	endpoint, err := db.GetOne[models.Endpoint](
-		db.Equal("id", endpoint_id),
-		db.Equal("tenant_id", tenant_id),
-	)
-	if err != nil {
-		return exception.NotFoundError(errors.New("Endpoint not found")).ToResponse()
-	}
-
-	endpoint.Enabled = false
 
-	if err := install_service.DisabledEndpoint(&endpoint); err != nil {
+	if err := install_service.DisabledEndpoint(endpoint_id, tenant_id); err != nil {
 		return exception.InternalServerError(errors.New("failed to disable endpoint")).ToResponse()
 	}
 

internal/service/install_service/state.go

@@ -144,12 +144,22 @@ func UninstallEndpoint(endpoint *models.Endpoint) error {
 	})
 }
 
-func EnabledEndpoint(endpoint *models.Endpoint) error {
-	if endpoint.Enabled {
-		return nil
-	}
-
+func EnabledEndpoint(endpoint_id string, tenant_id string) error {
 	return db.WithTransaction(func(tx *gorm.DB) error {
+		endpoint, err := db.GetOne[models.Endpoint](
+			db.WithTransactionContext(tx),
+			db.Equal("id", endpoint_id),
+			db.Equal("tenant_id", tenant_id),
+			db.WLock(),
+		)
+		if err != nil {
+			return err
+		}
+
+		if endpoint.Enabled {
+			return nil
+		}
+
 		endpoint.Enabled = true
 		if err := db.Update(endpoint, tx); err != nil {
 			return err
@@ -168,12 +178,21 @@ func EnabledEndpoint(endpoint *models.Endpoint) error {
 	})
 }
 
-func DisabledEndpoint(endpoint *models.Endpoint) error {
-	if !endpoint.Enabled {
-		return nil
-	}
-
+func DisabledEndpoint(endpoint_id string, tenant_id string) error {
 	return db.WithTransaction(func(tx *gorm.DB) error {
+		endpoint, err := db.GetOne[models.Endpoint](
+			db.WithTransactionContext(tx),
+			db.Equal("id", endpoint_id),
+			db.Equal("tenant_id", tenant_id),
+			db.WLock(),
+		)
+		if err != nil {
+			return err
+		}
+		if !endpoint.Enabled {
+			return nil
+		}
+
 		endpoint.Enabled = false
 		if err := db.Update(endpoint, tx); err != nil {
 			return err